[webkit-reviews] review denied: [Bug 180473] Make GraphicsLayer::dumpProperties dump m_offsetFromRenderer : [Attachment 328712] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has denied Frédéric Wang (:fredw) <fred.wang at free.fr>'s
request for review:
Bug 180473: Make GraphicsLayer::dumpProperties dump m_offsetFromRenderer
https://bugs.webkit.org/show_bug.cgi?id=180473

Attachment 328712: Patch

https://bugs.webkit.org/attachment.cgi?id=328712&action=review




--- Comment #22 from zalan <zalan at apple.com> ---
Comment on attachment 328712
  --> https://bugs.webkit.org/attachment.cgi?id=328712
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328712&action=review

> LayoutTests/compositing/ios/overflow-scroll-touch-tiles-expected.txt:47
> -  (bounds 800.00 897.00)
> +  (bounds 800.00 925.00)
>    (children 1
>      (GraphicsLayer
> -	 (bounds 800.00 897.00)
> +	 (bounds 800.00 925.00)
>	 (contentsOpaque 1)

It looks like it's more than just debug info.

> LayoutTests/compositing/tiling/tiled-reflection-inwindow-expected.txt:63
> -  (bounds 913.00 1206.00)
> +  (bounds 913.00 1221.00)
>    (children 1
>      (GraphicsLayer
> -	 (bounds 913.00 1206.00)
> +	 (bounds 913.00 1221.00)

This too.

>
LayoutTests/platform/ios-wk2/compositing/tiling/tiled-reflection-inwindow-expec
ted.txt:63
> -  (bounds 913.00 1149.00)
> +  (bounds 913.00 1163.00)
>    (children 1
>      (GraphicsLayer
> -	 (bounds 913.00 1149.00)
> +	 (bounds 913.00 1163.00)

?

>
LayoutTests/platform/mac-wk1/compositing/tiling/tiled-reflection-inwindow-expec
ted.txt:59
> -  (bounds 913.00 1146.00)
> +  (bounds 913.00 1161.00)
>    (children 1
>      (GraphicsLayer
> -	 (bounds 913.00 1146.00)
> +	 (bounds 913.00 1161.00)

?