[webkit-reviews] review granted: [Bug 180519] ServiceWorker Inspector: Use the SW's scope url for the remote inspection target metadata : [Attachment 328673] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 180519: ServiceWorker Inspector: Use the SW's scope url for the remote
inspection target metadata
https://bugs.webkit.org/show_bug.cgi?id=180519

Attachment 328673: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=328673&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 328673
  --> https://bugs.webkit.org/attachment.cgi?id=328673
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=328673&action=review

> Source/WebCore/workers/service/context/ServiceWorkerDebuggable.h:49
> +    String url() const override { return m_scopeURL; }

Could be final and made private, as should name() probably.

I also wonder whether url() could return a const String&.
Would need to change RemoteInspectionTarget and maybe use emptyString().