[webkit-reviews] review granted: [Bug 180515] Add logging for EditorState in RemoteLayerTree transactions : [Attachment 328663] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 180515: Add logging for EditorState in RemoteLayerTree transactions
https://bugs.webkit.org/show_bug.cgi?id=180515

Attachment 328663: Patch

https://bugs.webkit.org/attachment.cgi?id=328663&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 328663
  --> https://bugs.webkit.org/attachment.cgi?id=328663
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328663&action=review

> Source/WebKit/Shared/EditorState.cpp:240
> +    if (editorState.postLayoutData().typingAttributes != AttributeNone)

This probably should only try to dump post layout data if
!isMissingPostLayoutData. Otherwise, it'll hit an assertion in debug builds.