[webkit-reviews] review granted: [Bug 179752] [EME] Support generateRequest() in CDMFairPlayStreaming : [Attachment 328453] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 179752: [EME] Support generateRequest() in CDMFairPlayStreaming
https://bugs.webkit.org/show_bug.cgi?id=179752

Attachment 328453: Patch

https://bugs.webkit.org/attachment.cgi?id=328453&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 328453
  --> https://bugs.webkit.org/attachment.cgi?id=328453
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328453&action=review

> Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:143
> +	   if (result.first == "cbcs" || result.first == "cbc2" || result.first
== "cbc1")

Nit: these strings are used in several places, you should make them statics
with MAKE_STATIC_STRING_IMPL().

> Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:163
> +    InitDataRegistry::shared().registerInitDataType("sinf", {
CDMPrivateFairPlayStreaming::sanitizeSinf,
CDMPrivateFairPlayStreaming::extractKeyIDsSinf });

Nit: ASCIILiteral("sinf")