[webkit-reviews] review granted: [Bug 180486] [EME] Possible deadlock when aborting a SourceBufferPrivateAVFObjC append operation : [Attachment 328592] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 180486: [EME] Possible deadlock when aborting a SourceBufferPrivateAVFObjC
append operation
https://bugs.webkit.org/show_bug.cgi?id=180486

Attachment 328592: Patch

https://bugs.webkit.org/attachment.cgi?id=328592&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 328592
  --> https://bugs.webkit.org/attachment.cgi?id=328592
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328592&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:222
> +	   if (!dispatch_semaphore_wait(_abortSemaphore.get(),
dispatch_time(DISPATCH_TIME_NOW, NSEC_PER_MSEC * 100))) {
> +	       dispatch_semaphore_signal(_abortSemaphore.get());

Nit: why abortSemaphore rather than _abortSemaphore?

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:243
> +	   if (!dispatch_semaphore_wait(_abortSemaphore.get(),
dispatch_time(DISPATCH_TIME_NOW, NSEC_PER_MSEC * 100))) {
> +	       dispatch_semaphore_signal(_abortSemaphore.get());

Ditto.