[webkit-reviews] review requested: [Bug 176526] Add support for builderNameToIDMap in BuildbotSyncer : [Attachment 328622] Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 6 13:57:05 PST 2017
Aakash Jain <aakash_jain at apple.com> has asked for review:
Bug 176526: Add support for builderNameToIDMap in BuildbotSyncer
https://bugs.webkit.org/show_bug.cgi?id=176526
Attachment 328622: Updated patch
https://bugs.webkit.org/attachment.cgi?id=328622&action=review
--- Comment #10 from Aakash Jain <aakash_jain at apple.com> ---
Created attachment 328622
--> https://bugs.webkit.org/attachment.cgi?id=328622&action=review
Updated patch
> Then we should move it move it outside describe() and use it here.
Done.
> Also, we should add a new method to MockRemoteAPI
MockRemoteAPI already have a method "reset" which does exactly this. Used
MockRemoteAPI.reset().
Thanks for the suggestion. It simplified the server-tests changes
significantly.
More information about the webkit-reviews
mailing list