[webkit-reviews] review granted: [Bug 180381] Alternative Presentation Button: No need to unapply shadow DOM substitution when removed by page : [Attachment 328401] Patch and layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 6 13:48:31 PST 2017


Brent Fulgham <bfulgham at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 180381: Alternative Presentation Button: No need to unapply shadow DOM
substitution when removed by page
https://bugs.webkit.org/show_bug.cgi?id=180381

Attachment 328401: Patch and layout test

https://bugs.webkit.org/attachment.cgi?id=328401&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 328401
  --> https://bugs.webkit.org/attachment.cgi?id=328401
Patch and layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=328401&action=review

> Source/WebCore/editing/cocoa/AlternativePresentationButtonSubstitution.h:47
> +    void unapply(bool fromAPI);

This would be better with an enum, but I'm fine with this as-is.


More information about the webkit-reviews mailing list