[webkit-reviews] review granted: [Bug 180488] Start writing ServiceWorker registrations to disk : [Attachment 328595] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 180488: Start writing ServiceWorker registrations to disk
https://bugs.webkit.org/show_bug.cgi?id=180488

Attachment 328595: Patch

https://bugs.webkit.org/attachment.cgi?id=328595&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 328595
  --> https://bugs.webkit.org/attachment.cgi?id=328595
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328595&action=review

r=me

> Source/WebCore/workers/service/server/RegistrationDatabase.cpp:89
> +    std::unique_ptr<String> errorMessage;

Wh a pointer? string::isNull() not enough?

> Source/WebCore/workers/service/server/RegistrationDatabase.cpp:154
> +static String updateViaCacheToString(ServiceWorkerUpdateViaCache update)

Why are we storing them as Strings?

> Source/WebCore/workers/service/server/RegistrationDatabase.cpp:168
> +static String workerTypeToString(WorkerType workerType)

Why are we storing them as Strings?

> Source/WebCore/workers/service/server/RegistrationDatabase.h:39
> +class RegistrationDatabase : public CrossThreadTaskHandler {

FAST_MALLOC?

> Source/WebCore/workers/service/server/RegistrationStore.h:42
> +class RegistrationStore {

FAST_MALLOC?

> Source/WebCore/workers/service/server/RegistrationStore.h:44
> +    RegistrationStore(const String& databaseDirectory);

explicit?