[webkit-reviews] review denied: [Bug 180137] Build should fail early if needed Perl modules are not installed : [Attachment 327974] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied  review:
Bug 180137: Build should fail early if needed Perl modules are not installed
https://bugs.webkit.org/show_bug.cgi?id=180137

Attachment 327974: Patch

https://bugs.webkit.org/attachment.cgi?id=327974&action=review




--- Comment #21 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 327974
  --> https://bugs.webkit.org/attachment.cgi?id=327974
Patch

Emmanuele says:

"Yes, you can always assume they are there if Perl is there

If people go out of their way to install Perl and remove the core modules,
aside from breaking everything they can also add them back

It's not going to be any more complicated than installing a non-core module"

So sorry to trash your work Tom, but we don't need to test for JSON::PP, and
File::Copy::Recursive is a no-go. I think we should just never make the CMake
build depend on any non-core Perl modules.