[webkit-reviews] review granted: [Bug 176187] Web Inspector: Styles Redesign: display related pseudo-elements : [Attachment 328332] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 176187: Web Inspector: Styles Redesign: display related pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=176187

Attachment 328332: Patch

https://bugs.webkit.org/attachment.cgi?id=328332&action=review




--- Comment #6 from Timothy Hatcher <timothy at hatcher.name> ---
Comment on attachment 328332
  --> https://bugs.webkit.org/attachment.cgi?id=328332
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328332&action=review

> Source/WebInspectorUI/UserInterface/Models/DOMNode.js:640
> +	   if (this.isPseudoElement())
> +	       return "::" + this._pseudoType;

Does this have any broader impact on other places in the Inspector?

>
Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
128
> +	   Promise.all(pseudoElements.map((pseudoElement) =>
WI.cssStyleManager.stylesForNode(pseudoElement).refreshIfNeeded()))

Are the multiple the refreshIfNeeded() calls needed here? Wouldn't a refresh
have happened to get here
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.refresh) in the first place?