[webkit-reviews] review granted: [Bug 179831] Web Inspector: Styles Redesign: for newly added properties, pressing delete in empty value field should focus on name field : [Attachment 328316] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 179831: Web Inspector: Styles Redesign: for newly added properties,
pressing delete in empty value field should focus on name field
https://bugs.webkit.org/show_bug.cgi?id=179831

Attachment 328316: Patch

https://bugs.webkit.org/attachment.cgi?id=328316&action=review




--- Comment #8 from Timothy Hatcher <timothy at hatcher.name> ---
Comment on attachment 328316
  --> https://bugs.webkit.org/attachment.cgi?id=328316
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328316&action=review

> Source/WebInspectorUI/ChangeLog:12
> +	   * UserInterface/Views/SpreadsheetStyleProperty.js:

Oi, spreadsheet. Hmm.

>>> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:270
>>> +		 this._nameTextField.startEditing();
>> 
>> So Chrome's behavior is to only have backspace go from the value -> name
when its a new property. I think this is so that when you start editing an
existing property value and you select its contents and hit backspace, it only
clears the value but doesn't also jump to the name property. What is the
behavior after this patch is applied?
> 
> Interesting.	The behavior here doesn't distinguish between existing and new
properties.  Personally, I find this more useful, as it allows me to delete
properties a lot easier, but I could go either way.  How do you want to
proceed?

I find Chrome's behavior odd, and sounds like it could be a bug. I agree with
Devin, that pressing delete enough should jump from value to name and continue
editing there.