[webkit-reviews] review granted: [Bug 180367] Web Inspector: modernize InjectedScript a bit : [Attachment 328384] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Brian Burg
<bburg at apple.com>'s request for review:
Bug 180367: Web Inspector: modernize InjectedScript a bit
https://bugs.webkit.org/show_bug.cgi?id=180367

Attachment 328384: Patch

https://bugs.webkit.org/attachment.cgi?id=328384&action=review




--- Comment #5 from Timothy Hatcher <timothy at hatcher.name> ---
Comment on attachment 328384
  --> https://bugs.webkit.org/attachment.cgi?id=328384
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328384&action=review

> Source/JavaScriptCore/inspector/InjectedScriptBase.cpp:128
> +    out_resultObject =
BindingTraits<Protocol::Runtime::RemoteObject>::runtimeCast(resultObject);

Is "out_" prefix the style we use elsewhere? No a fan.

> Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.cpp:127
> +    // FIXME: remove this bridging code when generated protocol commands no
longer use OptOutput<T>.

Is there a bug you can reference?

> Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.cpp:256
> +    // FIXME: remove this bridging code when generated protocol commands no
longer use OptOutput<T>.

Ditto.