[webkit-reviews] review granted: [Bug 180450] ServiceWorkerGlobalScope prototype chain should be immutable : [Attachment 328525] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 180450: ServiceWorkerGlobalScope prototype chain should be immutable
https://bugs.webkit.org/show_bug.cgi?id=180450

Attachment 328525: Patch

https://bugs.webkit.org/attachment.cgi?id=328525&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 328525
  --> https://bugs.webkit.org/attachment.cgi?id=328525
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328525&action=review

> Source/WebCore/ChangeLog:9
> +	   do what we do for DOMWindow. This is covered by a web-platform-test

s/do/to

> Source/WebCore/workers/DedicatedWorkerGlobalScope.idl:37
> +    IsImmutablePrototypeExoticObjectOnPrototype,

It seems we have no tests for this change.
We should probably import WPT workers test suite to cover this (and maybe much
more!).