[webkit-reviews] review granted: [Bug 180456] InferredType should not use UnconditionalFinalizer : [Attachment 328538] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 5 17:39:35 PST 2017
Saam Barati <sbarati at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 180456: InferredType should not use UnconditionalFinalizer
https://bugs.webkit.org/show_bug.cgi?id=180456
Attachment 328538: the patch
https://bugs.webkit.org/attachment.cgi?id=328538&action=review
--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 328538
--> https://bugs.webkit.org/attachment.cgi?id=328538
the patch
View in context: https://bugs.webkit.org/attachment.cgi?id=328538&action=review
> Source/JavaScriptCore/runtime/InferredType.cpp:90
> + if (inferredType->m_structure)
> + visitor.append(inferredType->m_structure);
Doesn't append already do a null check for you?
More information about the webkit-reviews
mailing list