[webkit-reviews] review denied: [Bug 178498] Web Inspector: Styles Redesign: Typing semicolon at the end of value should move to the next property : [Attachment 328330] Patch

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <nvasilyev at apple.com> has denied Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 178498: Web Inspector: Styles Redesign: Typing semicolon at the end of
value should move to the next property
https://bugs.webkit.org/show_bug.cgi?id=178498

Attachment 328330: Patch

https://bugs.webkit.org/attachment.cgi?id=328330&action=review




--- Comment #8 from Nikita Vasilyev <nvasilyev at apple.com> ---
Comment on attachment 328330
  --> https://bugs.webkit.org/attachment.cgi?id=328330
Patch

r- because this patch doesn't work for values without any quotes, e.g.:

    color: red;

I think typing ; only in property value should have a special case.
Typing ; in property name shouldn't navigate to property value.

I implemented the special case for ":"
(https://trac.webkit.org/changeset/224906/webkit)
in SpreadsheetStyleProperty and not SpreadsheetTextField because I didn't want
to add any
CSS property logic to SpreadsheetTextField, so I could (hopefully) merge
SpreadsheetTextField
with SpreadsheetSelectorField later.