[webkit-reviews] review denied: [Bug 180174] REGRESSION: Layout Test storage/indexeddb/detached-iframe.html is a flaky crash : [Attachment 328353] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 180174: REGRESSION: Layout Test storage/indexeddb/detached-iframe.html is a
flaky crash
https://bugs.webkit.org/show_bug.cgi?id=180174

Attachment 328353: Patch

https://bugs.webkit.org/attachment.cgi?id=328353&action=review




--- Comment #9 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 328353
  --> https://bugs.webkit.org/attachment.cgi?id=328353
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328353&action=review

>> Source/WebCore/page/DOMWindow.cpp:954
>> +	InspectorInstrumentation::didPostMessage(*document(), *timer, state);
> 
> I don't understand how this will fix anything.  We are just changing the
assumption that the frame is non-null to an assumption that the document is
non-null.  Is that assumption more valid?  Why don't we want an early return or
something?

Yeah, I agree. I think the specific concern was at line 984, after
dispatchEvent() the document and frame might not exist so we should check
instead of assuming either one.