[webkit-reviews] review granted: [Bug 180441] WebAssembly: don't eagerly checksum : [Attachment 328494] patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted JF Bastien <jfbastien at apple.com>'s
request for review:
Bug 180441: WebAssembly: don't eagerly checksum
https://bugs.webkit.org/show_bug.cgi?id=180441

Attachment 328494: patch

https://bugs.webkit.org/attachment.cgi?id=328494&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 328494
  --> https://bugs.webkit.org/attachment.cgi?id=328494
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328494&action=review

r=me

> Source/JavaScriptCore/runtime/Options.h:481
> +    v(bool, eagerlyHashWebAssemblyModules, false, Normal, "Unnamed
WebAssembly modules are identified in backtraces through their hash, if
available.") \

nit: I'd name this starting with "use" to be consistent with many of our other
options. Maybe:
useEagerWebAssemblyModuleHashing?