[webkit-reviews] review granted: [Bug 180436] [Win64] Compile error in testmasm.cpp. : [Attachment 328482] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 5 13:06:55 PST 2017
Mark Lam <mark.lam at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 180436: [Win64] Compile error in testmasm.cpp.
https://bugs.webkit.org/show_bug.cgi?id=180436
Attachment 328482: Patch
https://bugs.webkit.org/attachment.cgi?id=328482&action=review
--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 328482
--> https://bugs.webkit.org/attachment.cgi?id=328482
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=328482&action=review
r=me with fix.
> Source/JavaScriptCore/assembler/testmasm.cpp:186
> + }), pointer + offset + (1ll << static_cast<int>(scale)) * length);
let's make it static_cast<size_t>(1). I think that is what we really want.
More information about the webkit-reviews
mailing list