[webkit-reviews] review granted: [Bug 180261] Implement https://w3c.github.io/ServiceWorker/#clients-claim : [Attachment 328470] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 5 12:20:24 PST 2017


Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 180261: Implement https://w3c.github.io/ServiceWorker/#clients-claim
https://bugs.webkit.org/show_bug.cgi?id=180261

Attachment 328470: Patch

https://bugs.webkit.org/attachment.cgi?id=328470&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 328470
  --> https://bugs.webkit.org/attachment.cgi?id=328470
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328470&action=review

r=me

> Source/WebCore/workers/service/server/SWServerWorker.cpp:142
> +    auto* registration = m_server.getRegistration(m_registrationKey);

I think a comment pointing the which part of which algorithm is implemented
would be helpful here.

> LayoutTests/http/tests/workers/service/serviceworkerclients-claim-worker.js:2
> +    if (event.request.url.indexOf("pinkelephant") !== -1)

lol


More information about the webkit-reviews mailing list