[webkit-reviews] review granted: [Bug 180431] [Win] Scrollbars are sometimes not rendered in accelerated compositing mode. : [Attachment 328477] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 5 11:39:44 PST 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 180431: [Win] Scrollbars are sometimes not rendered in accelerated
compositing mode.
https://bugs.webkit.org/show_bug.cgi?id=180431

Attachment 328477: Patch

https://bugs.webkit.org/attachment.cgi?id=328477&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 328477
  --> https://bugs.webkit.org/attachment.cgi?id=328477
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328477&action=review

> Source/WebKitLegacy/win/ChangeLog:9
> +	   Make sure virtual methods are actually overridden by adding the
'override' keyword.

What you're really saying here is "fix the signatures of GraphicsLayerClient
that should have been overridden, and use 'override' to make sure this doesn't
break in future.


More information about the webkit-reviews mailing list