[webkit-reviews] review granted: [Bug 180382] Implement setting of service worker to client in SWServer without going to WebProcess : [Attachment 328433] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 180382: Implement setting of service worker to client in SWServer without
going to WebProcess
https://bugs.webkit.org/show_bug.cgi?id=180382

Attachment 328433: Patch

https://bugs.webkit.org/attachment.cgi?id=328433&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 328433
  --> https://bugs.webkit.org/attachment.cgi?id=328433
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328433&action=review

r=me with minor comments.

> Source/WebCore/workers/service/server/SWServer.cpp:587
> +SWServerRegistration*
SWServer::registrationFromServiceWorkerIdentifier(ServiceWorkerIdentifier
identifier)

It would be good if we had a registration() getter on the SWServerWorker class
instead. It would be more reusable this way.

> Source/WebCore/workers/service/server/SWServer.h:148
> +    WEBCORE_EXPORT void registerServiceWorkerClient(ClientOrigin&&,
ServiceWorkerClientIdentifier, ServiceWorkerClientData&&, const
std::optional<ServiceWorkerIdentifier>&);

I think we should provide the name for the last parameter as it is non-obvious
to me.