[webkit-reviews] review granted: [Bug 180368] [Web App Manifest] Add SPI for applying a manifest to a top-level browsing context : [Attachment 328383] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted David Quesada
<david_quesada at apple.com>'s request for review:
Bug 180368: [Web App Manifest] Add SPI for applying a manifest to a top-level
browsing context
https://bugs.webkit.org/show_bug.cgi?id=180368

Attachment 328383: Patch

https://bugs.webkit.org/attachment.cgi?id=328383&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 328383
  --> https://bugs.webkit.org/attachment.cgi?id=328383
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328383&action=review

r=me

> Source/WebCore/page/PageConfiguration.h:81
> +    std::optional<ApplicationManifest> applicationManifest { std::nullopt };

No need to specify nullopt here. The default constructor will do that for you.