[webkit-reviews] review granted: [Bug 180358] <video> and scale() transforms yield shrunk small or clipped controls : [Attachment 328349] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 4 14:12:18 PST 2017


Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 180358: <video> and scale() transforms yield shrunk small or clipped
controls
https://bugs.webkit.org/show_bug.cgi?id=180358

Attachment 328349: Patch

https://bugs.webkit.org/attachment.cgi?id=328349&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 328349
  --> https://bugs.webkit.org/attachment.cgi?id=328349
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328349&action=review

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:226
> +	   while (node && node instanceof HTMLElement) {
> +	       transform = transform.multiply(new
WebKitCSSMatrix(getComputedStyle(node).transform));
> +	       node = node.parentNode;

What happens if any of these transforms change after the calculation?


More information about the webkit-reviews mailing list