[webkit-reviews] review denied: [Bug 180374] Don't force creation of process pool when enabling resource load statistics : [Attachment 328382] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 4 13:29:20 PST 2017


Alex Christensen <achristensen at apple.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 180374: Don't force creation of process pool when enabling resource load
statistics
https://bugs.webkit.org/show_bug.cgi?id=180374

Attachment 328382: Patch

https://bugs.webkit.org/attachment.cgi?id=328382&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 328382
  --> https://bugs.webkit.org/attachment.cgi?id=328382
Patch

Reading the code, I don't understand what it does or what it means.  It's very
not straightforward and if I wrote more code I would make this same mistake.
This has no tests.


More information about the webkit-reviews mailing list