[webkit-reviews] review granted: [Bug 179330] Web Inspector: Canvas Tab initial user interface needs some polish : [Attachment 328325] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 179330: Web Inspector: Canvas Tab initial user interface needs some polish
https://bugs.webkit.org/show_bug.cgi?id=179330

Attachment 328325: Patch

https://bugs.webkit.org/attachment.cgi?id=328325&action=review




--- Comment #11 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 328325
  --> https://bugs.webkit.org/attachment.cgi?id=328325
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328325&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js:-39
> -	   this._emptyFilterResultsElement = document.createElement("div");
> -	   this._emptyFilterResultsElement.classList.add("no-filter-results");

I see similar elements "no-filter-results" in
SpreadsheetRulesStyleDetailsPanel. Am I out of date or do those still exist? I
guess there was no CSS for that or its not hooked up (I see Devin has a patch
to hook up filtering).