[webkit-reviews] review granted: [Bug 179804] The WebProcess should use the NSRunLoop runloop type. : [Attachment 328351] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 179804: The WebProcess should use the NSRunLoop runloop type.
https://bugs.webkit.org/show_bug.cgi?id=179804

Attachment 328351: Patch

https://bugs.webkit.org/attachment.cgi?id=328351&action=review




--- Comment #28 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 328351
  --> https://bugs.webkit.org/attachment.cgi?id=328351
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328351&action=review

r=me, but please run that one change by AX people.

> Source/WebCore/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=179804

<rdar://problem/14012823>

> Source/WebKit/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=179804

<rdar://problem/14012823>

> Source/WebKit/Platform/IPC/mac/ConnectionMac.mm:590
> +	   return;

Does this early return cause accessibility stuff to fail? We should confirm
with James Craig or someone else on the accessibility team.