[webkit-reviews] review denied: [Bug 168447] AX: when invert colors is on, double-invert certain media elements in UserAgentStyleSheet : [Attachment 328331] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 4 08:07:24 PST 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Antoine Quint
<graouts at apple.com>'s request for review:
Bug 168447: AX: when invert colors is on, double-invert certain media elements
in UserAgentStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=168447

Attachment 328331: patch

https://bugs.webkit.org/attachment.cgi?id=328331&action=review




--- Comment #20 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 328331
  --> https://bugs.webkit.org/attachment.cgi?id=328331
patch

This patch has the following problems:
1. non-composited filters are slow. It probably takes a few additional
milliseconds to paint each filtered image, which makes page painting slower,
and will cause more tile flashing.
2. It overrides filters present in the page.  We know that sites use filters
for things like image desaturation, and this simply clobbers those filters. We
need a solution that doesn't break page content.


More information about the webkit-reviews mailing list