[webkit-reviews] review denied: [Bug 173540] AX: Layout test imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests1.html flaky crash : [Attachment 328334] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has denied Fujii Hironori <Hironori.Fujii at sony.com>'s
request for review:
Bug 173540: AX: Layout test
imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests1.html flaky
crash
https://bugs.webkit.org/show_bug.cgi?id=173540

Attachment 328334: Patch

https://bugs.webkit.org/attachment.cgi?id=328334&action=review




--- Comment #11 from zalan <zalan at apple.com> ---
Comment on attachment 328334
  --> https://bugs.webkit.org/attachment.cgi?id=328334
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328334&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:2753
> +	   m_deferredRecomputeIsIgnoredList.remove(element);

I was under the impression that any node detaching/destruction would go through
AXObjectCache::remove(). -apparently that's not the case. Chris, could you
confirm that and let me know if there are other entry points in AXObjectCache
for node detaching/destruction?
Regardless, this patch introduces yet another cleanup path for the deferred
objects which is highly error prone. I'd rather have them all in one function.