[webkit-reviews] review granted: [Bug 168447] AX: when invert colors is on, double-invert certain media elements in UserAgentStyleSheet : [Attachment 328331] patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at apple.com> has granted  review:
Bug 168447: AX: when invert colors is on, double-invert certain media elements
in UserAgentStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=168447

Attachment 328331: patch

https://bugs.webkit.org/attachment.cgi?id=328331&action=review




--- Comment #19 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 328331
  --> https://bugs.webkit.org/attachment.cgi?id=328331
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328331&action=review

> Source/WebCore/css/html.css:1223
> +  img, picture, video { filter: invert(100%); }  /* Images and videos
double-inverted. */

This should use four spaces to indent.

> LayoutTests/accessibility/smart-invert.html:13
> +let INVERTED_VALUE = "invert(1)";

These should be const.

> LayoutTests/accessibility/smart-invert.html:15
> +function $(id){

You only use this function to get the "result" element. Maybe you could just
get a reference to it and use it everywhere?