[webkit-reviews] review granted: [Bug 180335] Rename DestroyFunc to avoid redefinition on unified build : [Attachment 328296] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Caio Lima <ticaiolima at gmail.com>'s
request for review:
Bug 180335: Rename DestroyFunc to avoid redefinition on unified build
https://bugs.webkit.org/show_bug.cgi?id=180335

Attachment 328296: Patch

https://bugs.webkit.org/attachment.cgi?id=328296&action=review




--- Comment #2 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 328296
  --> https://bugs.webkit.org/attachment.cgi?id=328296
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328296&action=review

R=me. I recommend also removing the anonymous namespaces that wrap these in
this patch.

> Source/JavaScriptCore/heap/HeapCellType.cpp:40
> +struct HeapDestroyFunc {

Maybe call this one: DefaultDestroyFunc.