[webkit-reviews] review canceled: [Bug 180304] WorkerCacheStorageConnection should handle the case of terminated workers : [Attachment 328203] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has canceled youenn fablet
<youennf at gmail.com>'s request for review:
Bug 180304: WorkerCacheStorageConnection should handle the case of terminated
workers
https://bugs.webkit.org/show_bug.cgi?id=180304

Attachment 328203: Patch

https://bugs.webkit.org/attachment.cgi?id=328203&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 328203
  --> https://bugs.webkit.org/attachment.cgi?id=328203
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328203&action=review

>> Source/WebCore/ChangeLog:14
>> +	    Added a method to check a worker thread is still valid.
> 
> That type of technique won’t work 100% perfectly. It’s possible that the
thread has been fully deleted, but then a new thread allocated, and the new one
is in the same memory so happens to have the same address.

I guess I could further check the thread id if the pointer is still alive.