[webkit-reviews] review canceled: [Bug 180161] Improve initialization of script/root type of MathML renderers : [Attachment 327889] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 1 23:26:50 PST 2017


Frédéric Wang (:fredw) <fred.wang at free.fr> has canceled Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 180161: Improve initialization of script/root type of MathML renderers
https://bugs.webkit.org/show_bug.cgi?id=180161

Attachment 327889: Patch

https://bugs.webkit.org/attachment.cgi?id=327889&action=review




--- Comment #2 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 327889
  --> https://bugs.webkit.org/attachment.cgi?id=327889
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327889&action=review

> Source/WebCore/rendering/mathml/RenderMathMLScripts.h:52
> +    const ScriptsType m_scriptType;

Should be enum class and moved to the element class. I'll directly work on bug
161300.


More information about the webkit-reviews mailing list