[webkit-reviews] review granted: [Bug 180184] [Attachment Support] Implement SPI for clients to update a given attachment's data : [Attachment 327978] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 1 14:02:43 PST 2017


Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 180184: [Attachment Support] Implement SPI for clients to update a given
attachment's data
https://bugs.webkit.org/show_bug.cgi?id=180184

Attachment 327978: Patch

https://bugs.webkit.org/attachment.cgi?id=327978&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 327978
  --> https://bugs.webkit.org/attachment.cgi?id=327978
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327978&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:275
> +	   resultError = retainPtr(error);

Why even the retainPtr()?


More information about the webkit-reviews mailing list