[webkit-reviews] review granted: [Bug 180164] Free FontFaceSets may include fonts that were never actually added to them : [Attachment 328011] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 1 13:49:00 PST 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 180164: Free FontFaceSets may include fonts that were never actually added
to them
https://bugs.webkit.org/show_bug.cgi?id=180164

Attachment 328011: Patch

https://bugs.webkit.org/attachment.cgi?id=328011&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 328011
  --> https://bugs.webkit.org/attachment.cgi?id=328011
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328011&action=review

> Source/WebCore/css/CSSFontFaceSet.cpp:169
> +	       if (m_owningFontSelector)

Why the if check if it's always non-null?

> Source/WebCore/css/CSSFontFaceSet.h:110
> +    CSSFontSelector* m_owningFontSelector;

If this is always non-null why not use a ref?


More information about the webkit-reviews mailing list