[webkit-reviews] review granted: [Bug 179690] [MSE] Use correct range end checks in sourceBufferPrivateDidReceiveSample() : [Attachment 328100] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 179690: [MSE] Use correct range end checks in
sourceBufferPrivateDidReceiveSample()
https://bugs.webkit.org/show_bug.cgi?id=179690

Attachment 328100: Patch

https://bugs.webkit.org/attachment.cgi?id=328100&action=review




--- Comment #10 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 328100
  --> https://bugs.webkit.org/attachment.cgi?id=328100
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328100&action=review

r=me with nit:

> Tools/TestWebKitAPI/Tests/WebCore/SampleMap.cpp:-232
> -TEST_F(SampleMapTest, findSamplesWithinPresentationRange)
> -{
> -    auto& presentationMap = map.presentationOrder();
> -    auto iterator_range =
presentationMap.findSamplesWithinPresentationRange(MediaTime(0, 1),
MediaTime(1, 1));
> -    EXPECT_EQ(MediaTime(1, 1),
iterator_range.first->second->presentationTime());
> -    EXPECT_EQ(MediaTime(2, 1),
iterator_range.second->second->presentationTime());
> -
> -    iterator_range =
presentationMap.findSamplesWithinPresentationRange(MediaTime(1, 2),
MediaTime(3, 2));
> -    EXPECT_EQ(MediaTime(1, 1),
iterator_range.first->second->presentationTime());
> -    EXPECT_EQ(MediaTime(2, 1),
iterator_range.second->second->presentationTime());
> -
> -    iterator_range =
presentationMap.findSamplesWithinPresentationRange(MediaTime(9, 1),
MediaTime(21, 1));
> -    EXPECT_EQ(MediaTime(11, 1),
iterator_range.first->second->presentationTime());
> -    EXPECT_TRUE(presentationMap.end() == iterator_range.second);
> -
> -    iterator_range =
presentationMap.findSamplesWithinPresentationRange(MediaTime(-1, 1),
MediaTime(0, 1));
> -    EXPECT_EQ(MediaTime(0, 1),
iterator_range.first->second->presentationTime());
> -    EXPECT_EQ(MediaTime(1, 1),
iterator_range.second->second->presentationTime());
> -
> -    iterator_range =
presentationMap.findSamplesWithinPresentationRange(MediaTime(10, 1),
MediaTime(21, 2));
> -    EXPECT_TRUE(presentationMap.end() == iterator_range.first);
> -    EXPECT_TRUE(presentationMap.end() == iterator_range.second);
> -
> -    iterator_range =
presentationMap.findSamplesWithinPresentationRange(MediaTime(20, 1),
MediaTime(21, 1));
> -    EXPECT_TRUE(presentationMap.end() == iterator_range.first);
> -    EXPECT_TRUE(presentationMap.end() == iterator_range.second);
> -}
> -

Please restore this test (with the new name and possibly new values) before
landing.