[webkit-reviews] review granted: [Bug 180251] Nullptr deref in WebCore::RenderTableCaption::containingBlockLogicalWidthForContent : [Attachment 328095] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 1 10:23:29 PST 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 180251: Nullptr deref in
WebCore::RenderTableCaption::containingBlockLogicalWidthForContent
https://bugs.webkit.org/show_bug.cgi?id=180251

Attachment 328095: Patch

https://bugs.webkit.org/attachment.cgi?id=328095&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 328095
  --> https://bugs.webkit.org/attachment.cgi?id=328095
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328095&action=review

> LayoutTests/fast/table/caption-crash-when-layer-backed.html:6
> +    will-change: -webkit-transform; 

No prefix.

> LayoutTests/fast/table/caption-crash-when-layer-backed.html:8
> +    -webkit-background-clip: content; 

Not sure why this is needed.


More information about the webkit-reviews mailing list