[webkit-reviews] review granted: [Bug 179979] WebDriver: handle user prompts shown while executing scripts : [Attachment 327505] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 1 09:59:15 PST 2017


Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 179979: WebDriver: handle user prompts shown while executing scripts
https://bugs.webkit.org/show_bug.cgi?id=179979

Attachment 327505: Patch

https://bugs.webkit.org/attachment.cgi?id=327505&action=review




--- Comment #4 from Brian Burg <bburg at apple.com> ---
Comment on attachment 327505
  --> https://bugs.webkit.org/attachment.cgi?id=327505
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327505&action=review

r=me!

> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:569
> +	       for (auto id : m_evaluateJavaScriptFunctionCallbacks.keys()) {

Nit: s/id/key/g


More information about the webkit-reviews mailing list