[webkit-reviews] review granted: [Bug 180244] WebDriver: implement element property command : [Attachment 328089] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 180244: WebDriver: implement element property command
https://bugs.webkit.org/show_bug.cgi?id=180244

Attachment 328089: Patch

https://bugs.webkit.org/attachment.cgi?id=328089&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 328089
  --> https://bugs.webkit.org/attachment.cgi?id=328089
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328089&action=review

r=me

> Source/WebDriver/Session.cpp:1321
> +		   return;

It's not clear to me what will happen if element.`property` is undefined. Will
it return an error or not? Just looking at the W3C test names, I can't easily
tell that this case is covered.