[webkit-reviews] review granted: [Bug 175779] Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy : [Attachment 318670] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 31 17:42:28 PDT 2017


Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 175779: Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy
and resolveWebGLLoadPolicy
https://bugs.webkit.org/show_bug.cgi?id=175779

Attachment 318670: Patch

https://bugs.webkit.org/attachment.cgi?id=318670&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 318670
  --> https://bugs.webkit.org/attachment.cgi?id=318670
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318670&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebGLPolicy.mm:100
> +    return [[a absoluteString] isEqualToString:[b absoluteString]];

Why not NSURL equality?


More information about the webkit-reviews mailing list