[webkit-reviews] review granted: [Bug 176203] Add WKUIDelegatePrivate equivalent of WKPageUIClient's isPlayingAudioDidChange : [Attachment 319549] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 176203: Add WKUIDelegatePrivate equivalent of WKPageUIClient's
isPlayingAudioDidChange
https://bugs.webkit.org/show_bug.cgi?id=176203

Attachment 319549: Patch

https://bugs.webkit.org/attachment.cgi?id=319549&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 319549
  --> https://bugs.webkit.org/attachment.cgi?id=319549
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319549&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:121
> +    [webView loadRequest:[NSURLRequest requestWithURL:[[NSBundle mainBundle]
URLForResource:@"file-with-video" withExtension:@"html"
subdirectory:@"TestWebKitAPI.resources"]]];

I think there's a nicer way to write this but I don't remember what it is.
Check out TestWKWebView.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:123
> +    [webView evaluateJavaScript:@"playVideo()" completionHandler:^(id,
NSError *) { }];

This can definitely be nil.