[webkit-reviews] review granted: [Bug 176197] WSL should support makeptr (\) : [Attachment 319543] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 31 17:07:43 PDT 2017
Saam Barati <sbarati at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 176197: WSL should support makeptr (\)
https://bugs.webkit.org/show_bug.cgi?id=176197
Attachment 319543: the patch
https://bugs.webkit.org/attachment.cgi?id=319543&action=review
--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 319543
--> https://bugs.webkit.org/attachment.cgi?id=319543
the patch
View in context: https://bugs.webkit.org/attachment.cgi?id=319543&action=review
> Tools/WebGPUShadingLanguageRI/Evaluator.js:132
> + throw new Error("Cannot get type or argument; i = " + i + ",
argument = " + argument + ", type = " + type + "; in " + node);
if you use a template literal here I'd think it'd be easier to read.
More information about the webkit-reviews
mailing list