[webkit-reviews] review granted: [Bug 176135] Update CacheStorage caches only if it is updated : [Attachment 319422] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 176135: Update CacheStorage caches only if it is updated
https://bugs.webkit.org/show_bug.cgi?id=176135

Attachment 319422: Patch

https://bugs.webkit.org/attachment.cgi?id=319422&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 319422
  --> https://bugs.webkit.org/attachment.cgi?id=319422
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319422&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:236
> +    ++m_updateCounter;

We need to make sure to never forget to increment the updateCounter.  Maybe we
could wrap this in a function that indicates that we are marking the cache as
dirty instead of incrementing a mysterious integer.