[webkit-reviews] review granted: [Bug 176179] Add (entirely incorrect) fetching of ServiceWorker scripts : [Attachment 319522] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 176179: Add (entirely incorrect) fetching of ServiceWorker scripts
https://bugs.webkit.org/show_bug.cgi?id=176179

Attachment 319522: Patch

https://bugs.webkit.org/attachment.cgi?id=319522&action=review




--- Comment #2 from Andy Estes <aestes at apple.com> ---
Comment on attachment 319522
  --> https://bugs.webkit.org/attachment.cgi?id=319522
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319522&action=review

> Source/WebCore/workers/service/ServiceWorkerContainer.cpp:192
> +	   LOG_ERROR("ServiceWorkerContainer::jobResolvedWithRegistration
called but the containers ScriptExecutionContext is gone");

containers => container's

> Source/WebCore/workers/service/ServiceWorkerContainer.cpp:193
> +	   m_swConnection->failedFetchingScript(job, {
errorDomainWebKitInternal, 0, job.data().scriptURL, ASCIILiteral("Attempt to
fetch service worker script with no script execution context") });

This error says "script execution context", but the one above says
"ScriptExecutionContext". I'd be consistent.