[webkit-reviews] review granted: [Bug 176088] Stop using PolicyCallback : [Attachment 319378] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 31 13:34:39 PDT 2017
Andy Estes <aestes at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 176088: Stop using PolicyCallback
https://bugs.webkit.org/show_bug.cgi?id=176088
Attachment 319378: Patch
https://bugs.webkit.org/attachment.cgi?id=319378&action=review
--- Comment #4 from Andy Estes <aestes at apple.com> ---
Comment on attachment 319378
--> https://bugs.webkit.org/attachment.cgi?id=319378
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=319378&action=review
> Source/WebCore/loader/PolicyChecker.cpp:147
> + ResourceRequest requestCopy = request;
> +
m_frame.loader().client().dispatchDecidePolicyForNavigationAction(action,
request, didReceiveRedirectResponse, formState, [this, function =
WTFMove(function), request = WTFMove(requestCopy), formState =
makeRefPtr(formState), suggestedFilename =
WTFMove(suggestedFilename)](PolicyAction policyAction) mutable {
You can just capture request by value instead of explicitly making a copy.
More information about the webkit-reviews
mailing list