[webkit-reviews] review granted: [Bug 176177] WSL parser should pass the token as the origin to the AST : [Attachment 319504] the patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 176177: WSL parser should pass the token as the origin to the AST
https://bugs.webkit.org/show_bug.cgi?id=176177

Attachment 319504: the patch

https://bugs.webkit.org/attachment.cgi?id=319504&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 319504
  --> https://bugs.webkit.org/attachment.cgi?id=319504
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319504&action=review

r=me with nit.

> Tools/WebGPUShadingLanguageRI/Test.js:67
> +	   () => prepare("<test>", 0, "int foo(int x) { return x + y; }"),

Nit: Seems like you might want to make a wrapper for prepare in this file. I
expect you'll be calling it a lot...