[webkit-reviews] review denied: [Bug 131534] [GTK] Layout Test media/media-ended.html is flaky : [Attachment 319461] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 31 12:39:48 PDT 2017
Carlos Alberto Lopez Perez <clopez at igalia.com> has denied Ms2ger
<Ms2ger at igalia.com>'s request for review:
Bug 131534: [GTK] Layout Test media/media-ended.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=131534
Attachment 319461: Patch
https://bugs.webkit.org/attachment.cgi?id=319461&action=review
--- Comment #2 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 319461
--> https://bugs.webkit.org/attachment.cgi?id=319461
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=319461&action=review
> LayoutTests/media/media-ended.html:17
> - audio.src = findMediaFile("audio", "content/silence")
> + audio.src = findMediaFile("audio", "content/short")
good catch, but "short" is really short.. only 27 msecs! Not sure if is right
to use such short audio file here.
The main reason why this test was timing out on GTK bot, but not on other port
bots was because our aggressive time out values.
We raised that on r218270 (and is still lower than on Mac ports).
I have checked with wktesthunter that this test is now passing always since
r218270.
So I think we can just remove the flaky expectation and close this bug (leaving
the test as it was originally wrote with the silence audio file).
More information about the webkit-reviews
mailing list