[webkit-reviews] review granted: [Bug 176138] Do not create a salt if the CacheStorage engine should not persist : [Attachment 319428] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 31 10:39:58 PDT 2017


Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 176138: Do not create a salt if the CacheStorage engine should not persist
https://bugs.webkit.org/show_bug.cgi?id=176138

Attachment 319428: Patch

https://bugs.webkit.org/attachment.cgi?id=319428&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 319428
  --> https://bugs.webkit.org/attachment.cgi?id=319428
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319428&action=review

> Source/WebKit/NetworkProcess/cache/NetworkCacheData.h:-108
> -Salt makeSalt();

Won't we just need to put this back when we make persistent caches use salts?


More information about the webkit-reviews mailing list