[webkit-reviews] review granted: [Bug 176128] WKNavigationDelegatePrivate client redirect SPI needs to be able to detect redirects scheduled before the document finishes loading : [Attachment 319416] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 31 10:10:11 PDT 2017


Brady Eidson <beidson at apple.com> has granted David Quesada
<david_quesada at apple.com>'s request for review:
Bug 176128: WKNavigationDelegatePrivate client redirect SPI needs to be able to
detect redirects scheduled before the document finishes loading
https://bugs.webkit.org/show_bug.cgi?id=176128

Attachment 319416: Patch v1

https://bugs.webkit.org/attachment.cgi?id=319416&action=review




--- Comment #3 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 319416
  --> https://bugs.webkit.org/attachment.cgi?id=319416
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=319416&action=review

> Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:325
>     
webPage->injectedBundleLoaderClient().willPerformClientRedirectForFrame(*webPag
e, *m_frame, url, interval, fireDate);
> +
> +    // Notify the UIProcess.
> +   
webPage->send(Messages::WebPageProxy::DidScheduleClientRedirectForFrame(m_frame
->frameID(), url.string(), interval));

Why the different names?


More information about the webkit-reviews mailing list