[webkit-reviews] review granted: [Bug 176140] REGRESSION(r221226): [SOUP] libsoup-CRITICAL **: soup_cookies_to_cookie_header: assertion 'cookies != NULL' failed : [Attachment 319429] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 176140: REGRESSION(r221226): [SOUP] libsoup-CRITICAL **:
soup_cookies_to_cookie_header: assertion 'cookies != NULL' failed
https://bugs.webkit.org/show_bug.cgi?id=176140

Attachment 319429: Patch

https://bugs.webkit.org/attachment.cgi?id=319429&action=review




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 319429
  --> https://bugs.webkit.org/attachment.cgi?id=319429
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319429&action=review

> Source/WebCore/platform/network/soup/CookieJarSoup.cpp:92
> -    bool didAccessSecureCookies = false;
> +    if (!cookies)
> +	   return { { }, false };
>  
> +    bool didAccessSecureCookies = false;

I think it would be better to do this check after the loop. If all cookies are
secure and includeSecureCookies == IncludeSecureCookies::No, the list can be
empty (nullptr) after the loop.