[webkit-reviews] review granted: [Bug 176060] Throwing an exception in the DFG/FTL should not cause a jettison : [Attachment 319388] patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 176060: Throwing an exception in the DFG/FTL should not cause a jettison
https://bugs.webkit.org/show_bug.cgi?id=176060

Attachment 319388: patch

https://bugs.webkit.org/attachment.cgi?id=319388&action=review




--- Comment #16 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 319388
  --> https://bugs.webkit.org/attachment.cgi?id=319388
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319388&action=review

r=me with nit.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:5222
> +	       uint32_t errorType = currentInstruction[2].u.unsignedValue;

Nit: You could add names for throw_static_errors offsets!

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:10296
> +#if USE(JSVALUE64)
> +    callOperation(operationThrowDFG, valueRegs.gpr());
> +#else
> +    callOperation(operationThrowDFG, valueRegs);
> +#endif

Nit: instead of an #if can you add a callOperation(V_JITOperation_EJssUi,
JSValueRegs)?